Added border around scanning rectangle for scan view#558
Conversation
| if (framingRect != null && previewSize != null) { | ||
| Rect previewFramingRect = cameraPreview.getPreviewFramingRect(); | ||
| if (framingRect != null && previewFramingRect != null) | ||
| { |
There was a problem hiding this comment.
Please consider to not change the codestyle.
Unfortunately the maintainer is not active, otherwise I would make a pull request to check for right code style
Btw, thank you for the feature. Btw a screenshot would be cool, to see immediate what is introduced
There was a problem hiding this comment.
Really sorry for this late. I missed this. Could you please check if we can have this kind of border as border always helps in background setting.
|
I added your changes but I didn't see anything. How to use new changes? |
|
Hi @halilozel1903 . Please take a pull. Really sorry, Some issue happened from my side and latest changes were not pushed. I just got to know today by your comment only. Please check and let me know if you can see the changes.:-) |
How you doin’ ❓ Thanks. 😊 Why don't they accept what you do? |
|
May be Project Maintainers are not active. I hope they can provide feedbacks or suggestions on it. If this can be merged. :-) |
|
Maybe the maintainer @rkistner should have a second maintainer to avoid a no-progress-state like sadly a lot of other projects have ? |
3 participants
No description provided.